fix: cli throws an error when thirdPartyAuth is enabled, but authProvider is not included#14284
Merged
otaviomacedo merged 1 commit intodevfrom Oct 21, 2025
Merged
Conversation
…rovider` is not included
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ShadowCat567
approved these changes
Oct 20, 2025
Contributor
ShadowCat567
left a comment
ShadowCat567
left a comment
There was a problem hiding this comment.
Considering the previous cli maintainers used this includes('accounts.google.com') previously, I'm not too concerned about these CodeQL errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function that loads the
awscloudformationprovider assumes that theauthProvidersproperty is present wheneverthirdPartyAuthis present. This object comes from a user controlled file (parameter.jsonin the application resource dir), so there is no guarantee that this is true.Default to an empty array if it's not present.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.